[Libvirt-cim] [PATCH] [CU] Fix const pointer warning

Zhengang Li zli at linux.vnet.ibm.com
Fri Feb 29 01:43:22 UTC 2008


Dan Smith wrote:

> ZL> diff -r b2606bc023a8 -r 8ef92e008bcb std_indication.c
> ZL> --- a/std_indication.c	Tue Feb 26 15:16:00 2008 -0500
> ZL> +++ b/std_indication.c	Wed Feb 27 09:48:23 2008 +0800
> ZL> @@ -214,7 +214,7 @@ CMPIStatus stdi_activate_filter(CMPIIndi
> ZL>          char *cn = NULL;
>          
> ZL>          _ctx = (struct std_indication_ctx *)mi->hdl;
> ZL> -        cn = CLASSNAME(op);
> ZL> +        cn = (char *)CLASSNAME(op);
> ZL>          s = stdi_set_ind_filter_state(_ctx, cn, true);
> 
> Shouldn't we change cn to be a const char *, instead of casting it to
> char *?
It was my 1st idea. And then it turns out the 2nd param to 
stdi_set_ind_filter_state() is a 'char *'. Change that, too?

> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim


-- 
- Zhengang




More information about the Libvirt-cim mailing list