[Libvirt-cim] [PATCH 0 of 5] #2 EAFP and RAFP support invalid references.
Jay Gagnon
grendel at linux.vnet.ibm.com
Thu Jan 3 15:09:16 UTC 2008
Looks like a good set to me. The one patch is a little bit incongruous,
but the total volume is quite manageable so it's not really an issue.
Also, having a patch that may or may not fit into a set is far less of a
concern to me than having changes that may or may not belong in a
patch. Each individual patch is clear and consistent, so don't worry.
Also, the (inst == NULL) check is a good catch. I wouldn't be surprised
if we need that in a few more spots, especially since we've been a bit
inconsistent when it comes to the "Is a NULL instance an error or just a
NULL instance?" question.
--
-Jay
More information about the Libvirt-cim
mailing list