[Libvirt-cim] [PATCH] Make NetworkPool use libvirt's virtual network API
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Fri Jan 4 18:45:35 UTC 2008
Dan Smith wrote:
> KR> It looks like virNetworkFree() doesn't handle NULL pointers. I think
> KR> most of the other libvirt functions do though.
>
> Actually, it looks like it does, it just complains about it. For some
> reason, virConnectClose() quietly returns on a bad pointer, but
> virDomainFree() and virNetworkFree() both complain. I'm not sure it's
> a big deal, or worth making free conditional on network!=NULL. I
> imagine at some point we'll wrap the libvirt error handler, which
> would allow us to hide this warning.
>
Oh, interesting. Thanks for taking a look. It's surprising, because it
doesn't seem like any of the other Free() functions return this kind of
warning. Either that, or I'm not paying enough attention. =)
Thanks!
More information about the Libvirt-cim
mailing list