[Libvirt-cim] [PATCH 1 of 3] Fix xml_parse_test if no emulator is defined

[Jay Gagnon]

Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1199827433 28800
> # Node ID 7272934dc44185bef3923c86fa19961d299518fd
> # Parent  10d141f683370b6f04637bb9ad059bbd92051ce0
> Fix xml_parse_test if no emulator is defined
>
> Signed-off-by: Dan Smith <danms at us.ibm.com>
>
> diff -r 10d141f68337 -r 7272934dc441 libxkutil/xml_parse_test.c
> --- a/libxkutil/xml_parse_test.c	Tue Jan 08 10:51:44 2008 -0800
> +++ b/libxkutil/xml_parse_test.c	Tue Jan 08 13:23:53 2008 -0800
> @@ -121,7 +121,7 @@ static void print_devices(struct domain 
>          for (i = 0; i < dominfo->dev_vcpu_ct; i++)
>                  print_dev_vcpu(&dominfo->dev_vcpu[i], d);
>
> -        if (dominfo->type != DOMAIN_XENPV) {
> +        if ((dominfo->type != DOMAIN_XENPV) && (dominfo->dev_emu)) {
>                  fprintf(d, "\n-- Emulator --\n");
>                  print_dev_emu(dominfo->dev_emu, d);
>          }
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>   
Well I gotta say, I'm a bit disappointed.  All that lead up to the set,
and the first patch doesn't even produce a vertical scrollbar in
thunderbird.  At the very least you could have done some pointer arithmetic.


+1, I guess.

-- 

-Jay