[Libvirt-cim] [PATCH] HS: returns results for wrong object path
Heidi Eckhart
heidieck at linux.vnet.ibm.com
Wed Jan 9 09:14:30 UTC 2008
Dan Smith wrote:
> HE> + if (STREQC(classname, "VirtualSystemManagementService")) {
> HE> + s = get_vsms(ref, &inst, _BROKER);
> HE> + }
> HE> + else if (STREQC(classname, "ResourcePoolConfigurationService")) {
> HE> + s = rpcs_instance(ref, &inst, _BROKER);
> HE> + }
> HE> + else if (STREQC(classname, "VirtualSystemMigrationService")) {
> HE> + s = get_migration_service(ref, &inst, _BROKER);
> HE> + }
> HE> + if (s.rc != CMPI_RC_OK)
> HE> + return s;
>
> This doesn't fit the style of the rest of the code. The "else if"
> statements should be on the same line as the closing brace, and there
> should be a blank line before the second and unrelated if.
>
>
Fixed in the updated version.
--
Regards
Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor
More information about the Libvirt-cim
mailing list