[Libvirt-cim] [PATCH 3 of 3] EC: Validation of client given object path missing

[Kaitlin Rupert]

Heidi Eckhart wrote:
> # HG changeset patch
> # User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
> # Date 1199971253 -3600
> # Node ID d4471d3ac4766af68f6bf151813f0ec246b0e409
> # Parent  fd476f08b35e235ba7e50d326e5602018ebc3730
> EC: Validation of client given object path missing

> 
>          conn = connect_by_classname(_BROKER, CLASSNAME(ref), &s);
>          if (s.rc != CMPI_RC_OK)
> -                goto error1;
> +                goto out;

A question not directly related to this patch:

Shouldn't we also check to see if conn is NULL here?  If 
connect_by_classname() is unable to connect, an error value isn't 
assigned to the CMPIStatus variable.  Or possibly a better approach 
would be to modify connect_by_classname() so that it sets an error.

-- 
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com