[Libvirt-cim] [PATCH] Fix connect_by_classname() to set error status when connect fails
Heidi Eckhart
heidieck at linux.vnet.ibm.com
Fri Jan 11 11:18:39 UTC 2008
Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1200005355 28800
> # Node ID bb05fe5857468c3a524a29c06390d90ac84dde68
> # Parent ca8dc23eacc44970a2d79978bc9de65aaa600b92
> Fix connect_by_classname() to set error status when connect fails.
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
> diff -r ca8dc23eacc4 -r bb05fe585746 libxkutil/misc_util.c
> --- a/libxkutil/misc_util.c Wed Jan 09 13:08:17 2008 +0100
> +++ b/libxkutil/misc_util.c Thu Jan 10 14:49:15 2008 -0800
> @@ -71,7 +71,9 @@ virConnectPtr connect_by_classname(const
>
> conn = virConnectOpen(uri);
> if (!conn) {
> - CU_DEBUG("Unable to connect to `%s'", uri);
> + cu_statusf(broker, s,
> + CMPI_RC_ERR_FAILED,
> + "Unable to connect to `%s'", uri);
> return NULL;
> }
>
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
>
As already described in the comment for the other patch, this would
break the CIM model and operations. Please do not apply.
-1
--
Regards
Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor
More information about the Libvirt-cim
mailing list