[Libvirt-cim] [PATCH] [CU] Add function to validate a client given object path

[Dan Smith]

HE> diff -r 2a52fc3c4bbc -r 393ba1344f5b libcmpiutil.h
HE> --- a/libcmpiutil.h	Thu Dec 13 11:10:59 2007 +0100
HE> +++ b/libcmpiutil.h	Fri Jan 11 10:33:08 2008 +0100
HE> @@ -377,6 +377,10 @@ int inst_list_add(struct inst_list *list
HE>   *          or NULL if all match
HE>   */
HE>  const char *cu_compare_ref(const CMPIObjectPath *ref,
HE> +                           const CMPIInstance *inst);
HE> +
HE> +CMPIStatus cu_validate_ref(const CMPIBroker *broker,
HE> +                           const CMPIObjectPath *ref,
HE>                             const CMPIInstance *inst);

How about a comment before the function prototype explaining that it's
just like cu_compare_ref() but returns a CMPIStatus?  I was confused
about how it's different when I first looked at it :)

In general, I've tried to keep libcmpiutil.h pretty well documented,
so I'd like to not depart from doing so.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080111/1ed24358/attachment.sig>