[Libvirt-cim] [PATCH] Relax the KVM type detection logic

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Mon Jan 14 17:16:05 UTC 2008


Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1200067225 28800
> # Node ID a353b12b24858b16b3b6d77940178f5cd672bdce
> # Parent  4ae48640b6dfaf77c60300aa2f41a3be9395bf83
> Relax the KVM type detection logic
> since it was too strict for no reason.
> 
> Signed-off-by: Dan Smith <danms at us.ibm.com>
> 
> diff -r 4ae48640b6df -r a353b12b2485 libxkutil/device_parsing.c
> --- a/libxkutil/device_parsing.c	Fri Jan 11 07:59:47 2008 -0800
> +++ b/libxkutil/device_parsing.c	Fri Jan 11 08:00:25 2008 -0800
> @@ -652,8 +652,7 @@ static int parse_os(struct domain *domin
>          if ((STREQC(dominfo->os_info.fv.type, "hvm")) &&
>              (STREQC(dominfo->typestr, "xen")))
>                  dominfo->type = DOMAIN_XENFV;
> -        else if ((STREQC(dominfo->os_info.fv.type, "hvm")) &&
> -                 (STREQC(dominfo->typestr, "kvm")))
> +        else if (STREQC(dominfo->typestr, "kvm"))
>                  dominfo->type = DOMAIN_KVM;

Seems reasonable since we only care about the KVm typestr. +1

-- 
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com




More information about the Libvirt-cim mailing list