[Libvirt-cim] [PATCH 1 of 2] Change xmlgen core to handle batches of devices

Dan Smith danms at us.ibm.com
Wed Jan 16 00:23:36 UTC 2008


KR> I think this should be if (ret == -1) here.

Yep, thanks.

KR> No complaint, just a question - why is the count being hardcoded
KR> to 1 here?

Because I'm passing a single device instead of an array of devices.
The device_to_xml() function is used elsewhere to convert a single
device to xml, so this just acts as a type-detecting, list-faking,
wrapper to the concat_devxml() function.  Since the concat_devxml()
function has a strange syntax and depends on internal-to-that-file
functions, it seems better to have an external interface that is a bit
more sane :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080115/1fa1ed31/attachment.sig>


More information about the Libvirt-cim mailing list