[Libvirt-cim] [PATCH 4 of 5] Fix KVM network xml to use virtual network type

[Dan Smith]

JG> Is making the Xen/KVM distinction on network type safe?  (That's
JG> not a rhetorical way of saying I don't think it is, this is just
JG> something I have basically no info on.)

I'm not sure what you're getting at.  I don't think that right now
anything but a KVM guest can have a network type of "network", so it's
a reasonable key for the moment.  However, as Kaitlin pointed out (and
I eluded to in the updated patch with a comment), I'm only claiming
support for "bridge" interfaces on Xen and "[virtual] network"
interfaces on KVM.

That call really needs an additional bit of information to know what
kind of domain it is to be 100% safe, but I didn't want to refactor it
all right now.  Perhaps just adding a more specific type enum to the
network struct would be a good idea.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080116/c4354b3e/attachment.sig>