[Libvirt-cim] [PATCH] Fix VSMS.RemoveResources()

Dan Smith danms at us.ibm.com
Tue Jan 22 18:24:05 UTC 2008


# HG changeset patch
# User Dan Smith <danms at us.ibm.com>
# Date 1201028159 28800
# Node ID 47438edf32be70e65bdb814ab609a70304fad2f4
# Parent  c92db5f8d2b108163d75b32f906c7b55fa4f2854
Fix VSMS.RemoveResources()

My previous work on the xmlgen code caused us to stop skipping VIRT_DEV_UNKNOWN
devices in the full-system XML generation case.  Since a delete operation just
marks devices as such, we should skip them.

Signed-off-by: Dan Smith <danms at us.ibm.com>

diff -r c92db5f8d2b1 -r 47438edf32be libxkutil/xmlgen.c
--- a/libxkutil/xmlgen.c	Tue Jan 22 10:20:51 2008 -0800
+++ b/libxkutil/xmlgen.c	Tue Jan 22 10:55:59 2008 -0800
@@ -322,7 +322,11 @@ static bool concat_devxml(char **xml,
         int i;
 
         for (i = 0; i < count; i++) {
-                func(&_xml, &list[i]);
+                /* Deleted devices are marked as VIRT_DEV_UNKNOWN
+                 * and should be skipped
+                 */
+                if (list[i].type != VIRT_DEV_UNKNOWN)
+                        func(&_xml, &list[i]);
         }
 
         astrcat(xml, _xml);




More information about the Libvirt-cim mailing list