[Libvirt-cim] [PATCH 2 of 2] Check CreationClassName in MigrationService

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Jan 24 21:37:40 UTC 2008


Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1201194993 28800
> # Node ID 3717fb3202ecf289ffb05a94f7d2375658c4191b
> # Parent  b0b9833dfa219a3e9a7898c0b6f5bab7afaf460a
> Check CreationClassName in MigrationService
> 
> Signed-off-by: Dan Smith <danms at us.ibm.com>
> 
> diff -r b0b9833dfa21 -r 3717fb3202ec src/Virt_VSMigrationService.c
> --- a/src/Virt_VSMigrationService.c	Thu Jan 24 09:16:26 2008 -0800
> +++ b/src/Virt_VSMigrationService.c	Thu Jan 24 09:16:33 2008 -0800
> @@ -204,6 +204,15 @@ static CMPIStatus vs_migratable_host(CMP
>                  return s;
>          }
> 
> +        if (!check_refs_pfx_match(ref, system)) {
> +                printf("Classname: %s\n", CLASSNAME(system));

This should be a CU_DEBUG().

I was also going to comment that the check_refs_pfx_match() name is a 
bit misleading since we also check the classname.  But it never hurts to 
verify the classname (even if you just want to verify the prefix), so 
the function name is fine.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list