Fw: [Fwd: [Libvirt-cim] [PATCH] [TEST] A few migration related fixes]

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jul 1 19:33:50 UTC 2008


>  > -    destroy_and_undefine_domain(dom_name, options.ip)  
>  > +    destroy_and_undefine_domain(dom_name, options.ip)
>  >
>  >      return status
>  >
>   Do you think we should also to call destroy_and_undefine_domain() 
> below based
>   on your patch?
> 
>      status, cs_ref = start_guest_get_ref(options.ip, dom_name)
>      if status != PASS:
> +        destroy_and_undefine_domain(dom_name, options.ip)
>          return FAIL
> 

start_guest_get_ref() calls destroy_and_undefine_domain() if an 
exception is encountered.  This is also the only place the FAIL status 
is set in start_guest_get_ref().  However, the error checking in 
start_guest_get_ref() could be improved, so I'll resend.

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list