[Libvirt-cim] [PATCH] [TEST] Some VirtualSystemManagementService -t 02_destroysystem.py cleanup

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jul 1 20:43:53 UTC 2008


>  > +    ret = cxml.define(options.ip)
>  > +    if not ret:
>  > +        logger.error("Failed to define the dom: %s", default_dom)
>  > +        return FAIL
>  > +    ret = cxml.start(options.ip)
>  > +    if not ret:
>  > +        logger.error("Failed to define the dom: %s", default_dom)
> 
>    It's better to log the error as "logger.error("Failed to create(or 
> start) the dom: %s", default_dom)",
>    which more reflect the actual failure.
> 

Yes, good catch - thanks!  I had a copy/paste error here.

I'll change it to be "Failed to start the dom: %s" since we're starting 
it (not creating it).
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list