[Libvirt-cim] [PATCH] [TEST] Fix potiential false positive in CS 02
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Mon Jul 21 15:16:14 UTC 2008
Dan Smith wrote:
> KR> Is this test really checking to make sure EnumInstances() doesn't
> KR> return an error? If so, the name of the test is misleading. And
> KR> other tests cover this already (CS 01_enum.py).
>
> Well, I looked at the current test, as well as the original version of
> it and I'm all confused now. I thought it was doing something
> different than it is (and was). So, as you say, I think it makes
> sense to remove Xen and XenFV from the list of runnable platforms and
> let this test ensure that the providers can handle the case where
> there are no domains on the system for LXC and KVM.
>
Sure, that works for me. Right now, I have Xen and XenFV in the list
(the test should always skip on them). I'll send an updated patch that
fixes this test so that it is KVM and LXC only.
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list