[Libvirt-cim] [PATCH] [TEST] #2 Fix potiential false positive in AC 01

[Kaitlin Rupert]

>> It can be moved outside of this function to help with clarity.
>>
>>
>> and also we should be checking len(ac) != 4 to make sure that AC
>>> values == enum of MemoryPool + ProcessorPool + DiskPool + 
>>> NetworkPool. Any specific reason for not doing this ?
>>> otherwise +1 for me.
>>
>> You can't guarantee 4 pools. The test creates a disk pool and a 
>> network pool, but it's possible for additional net and disk pools to 
>> exist on the system. That's why you want to check len(ac) != len(pools).
>>
> yes I missed this scenario. yes we shld be checking for len(ac) is 
> atleast 4 and not less than that since we are sure atleast 1 
> processorpool + 1 memorypool + atleast 1 networkpool + atleast 1 
> diskpool will exist.
> 

Yep, that makes sense!  Will send a new patch =)

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com