[Libvirt-cim] [PATCH] [TEST] Update VSMigrationS.05 for XenFV support, also convert test_xml call to vxml

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jul 22 16:53:31 UTC 2008


>  @do_main(sup_types)
>  def main():
>      options = main.options
> -    xmlfile = testxml(test_dom)
> +
> +    virt_xml = vxml.get_class(options.virt)
> +    cxml = virt_xml(test_dom)
> +    ret = cxml.create(options.ip)
> +    if not ret:
> +        logger.error("Error create domain %s" % test_dom )
> +        return FAIL
> 

Since you're creating the guest using cxml.create, can you replace the 
destroy_and_undefine_domain() with cxml.destroy() and cxml.undefine() calls?

If a test is updated to use the .define() / .create() calls, I'd like to 
phase out the destroy_and_undefine_domain() and related calls.  These 
calls are still necessary if a guest is being defined using DefineSystem().

Don't forget to remove the "from XenKvmLib.test_doms import 
destroy_and_undefine_domain" line as well.

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list