[Libvirt-cim] [PATCH] [TEST] Updating 04_hs_to_EAPF.py to use the verify_device_values() included in the logicaldevices.py

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Jul 23 20:50:33 UTC 2008


Deepti B Kalakeri wrote:
> 
> 
> Kaitlin Rupert wrote:
>>> - else:
>>> - status = FAIL
>>> + status = verify_device_values(assoc_eafp_info, CCName, + 
>>> eafp_values, virt='Xen')
>>> +
>>
>> There's an extra param included here. CCName isn't needed.
>>
> 
> The definition of the verify_device_values() in logicaldevices.py takes 
> the 4 arguments and hence all the 4 which includes CCName is required.
> The following is the definition in logicaldevices.py :
> 
> def verify_device_values(assoc_info, CCName, list_values, virt='Xen'):
> dev_cnames = ['LogicalDisk', 'Memory', 'NetworkPort', 'Processor']
> for i in range(len(dev_cnames)):
> dev_cnames[i] = get_typed_class(virt, dev_cnames[i])
> 

Yes, my mistake here.  I had applied this patch before the patch with 
the logicaldevices fix.  This patch looks good!
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list