[Libvirt-cim] [PATCH] [TEST]#2 Update HostSystem.04 for XenFV/KVM/LXC support

[Kaitlin Rupert]

> +    ret = vsxml.define(server)
> +    if not ret:
> +        logger.error("Failed to define the dom: '%s'", test_dom)
> +        return FAIL
> +    cleanup_restore(server, virt=virt)

This call isn't needed.

>      # Verify DiskPool on machine
>      status = create_diskpool_file() 
>      if status != PASS:
>          return status

You'll need to clean up the guest before returning.

> +    # Create NetPool on machine
> +    status, net_name = create_netpool_conf(server, virt)

By default, create_netpool_conf uses the existing network pool if one 
exists.  You'll need to supply "False" here because you clean up the 
network pool below.

The behavior of this function should change at some point, I think using 
the existing network pool should only be used in special conditions.

> +    if status != PASS:
> +        logger.error('Unable to create network pool')
> +        return FAIL

You'll need to clean up the diskpool and the guest here.

> 
>      # Get the hostedResourcePool info first
>      cn  = classname
> -    an  = "Xen_HostedResourcePool"
> +    an  = get_typed_class(virt, "HostedResourcePool")
>      qcn = "Device Pool"
> -    status, pool = get_assocname_info(server, cn, an, qcn, host_name)
> +    status, pool = get_assocname_info(server, cn, an, qcn, host_name, virt)
>      if status != PASS:
>          return status

You'll need to clean up the diskpool and netpool before returning.

> -
> -    # One pool for each Device type, hence len should be 4 
> +    # One pool for each Device type, hence len should be 4
>      exp_len = 4
>      status = status = check_len(an, pool, qcn, exp_len)
>      if status != PASS:
>          return FAIL

You'll need to clean up the diskpool and netpool before returning.


-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com