[Libvirt-cim] [PATCH] Fix VSMS resource_add so that and additional tag is not added for processor
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Tue Jun 3 17:53:21 UTC 2008
Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1212425931 25200
> # Node ID 7cf0b0142edb638ce43cc8f3209eef12b2f5e04b
> # Parent 0c8d4baf3ee1f6eb96f7d1d49276fa6cc44c4685
> Fix VSMS resource_add so that and additional tag is not added for processor.
>
> The same is also true for memory. Also, be sure not to increment the count for processor and memory since a guest will not have muultiple tags for these devices.
>
> Remove check for memory after find_list(). We don't want to skip this becuase it's possible to update the memory of a defined guest. It is not possible to update the memory of a running guest, but this case is already handled by attach_device() in device_parsing.c
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
> diff -r 0c8d4baf3ee1 -r 7cf0b0142edb src/Virt_VirtualSystemManagementService.c
Please ignore this patch. If we need to modify the memory or processors
of a guest, ModifyResource() should be used.
This patch was to address the problem where AddResource() returns a
success if a user attempts to add processors to a defined guest.
However, the number of processors doesn't change, so an error should be
returned.
Will send a different patch to handle this.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list