[Libvirt-cim] [PATCH] [TEST] Fix CIM_REV to handle non integer strings

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Jun 4 20:13:05 UTC 2008


>>
>> -CIM_REV = int(os.getenv("CIM_REV"))
>> +rev = os.getenv("CIM_REV").strip("+")
>> +if rev.isalnum():
>>   
> Are we planning to use alphabets in the REV string, if yes then the I 
> say +1 for the changes.
> If the REV string does not contain alphabets then we can use isdigit() 
> instead.
> 
> Thanks and Regards,
> Deepti.

Good point. I don't expect there to be any alphabetic characters. I'll 
send a new patch using isdigit().

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list