[Libvirt-cim] [PATCH 3 of 4] [TEST] Updating the 41_cs_to_settingdefinestate.py tc of ComputerSystem

[Kaitlin Rupert]

>  sup_types = ['Xen']
> 
> @@ -75,43 +77,7 @@
>  test_vcpus  = 1
>  test_mem    = 128
>  test_mac    = "00:11:22:33:44:aa"
> -test_disk   = 'xvda'
>  vstype      = 'Xen'

Instead of vstype, you can use options.virt

> +    if virt == "Xen":
> +        test_disk = "xvda"
> +    else:
> +        test_disk = "hda"

Test currently only supports Xen - no need to modify this, just curious 
if you plan to modify this to support XenFV or KVM in the future.

> +    virt_xml =  get_class(virt)
> +    vsxml_info = virt_xml(test_dom, mem = test_mem,
> +                                  vcpus=test_vcpus,
> +                                    mac = test_mac,
> +                                  disk = test_disk)

Strange indentation here.

> 
> -def get_setdefstate_verify_RASD_build_vssdc_input(server, sd_assoc_info):
> +def get_setdefstate_verify_RASD_build_vssdc_input(server, virt, vsxml, test_disk, 
> +                                                                  sd_assoc_info):

Strange indentation here as well.

> -    status, in_vssdc_list = get_setdefstate_verify_RASD_build_vssdc_input(server, \
> -                                                                     sd_assoc_info)
> +    status, in_vssdc_list = get_setdefstate_verify_RASD_build_vssdc_input(server, 
> +                                                                            virt,
> +                                                                            vsxml,
> +                                                                        test_disk,
> +                                                                    sd_assoc_info)

And here too.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com