[Libvirt-cim] [PATCH 2 of 6] Add domain information store utilities

[Dan Smith]

KR> Need to close the connection here.

No, because I didn't open it, I just grabbed it from the
virDomainPtr.

KR> Before returning, the xmlParserCtxtPtr should be freed.

Yep, thanks.

KR> Not sure why you only return false here.  In every place you've
KR> called it, you're not capturing the return, so the value doesn't
KR> really matter. However, just curious why it's false.

Because I didn't change it once I implemented that function :P

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080618/e44de914/attachment.sig>