[Libvirt-cim] [PATCH] Fix missing braces in HD

Heidi Eckhart heidieck at linux.vnet.ibm.com
Mon Mar 3 10:26:33 UTC 2008


Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1204315089 28800
> # Node ID 9ca3b9b245f8af8f960a4d1e3557adf536daabee
> # Parent  b2f223ca9105b8f416ab768a1363df910d6815d4
> Fix missing braces in HD.
>
> Some missing braces cause host_to_vs() to exit before enumerating the instances.
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
> diff -r b2f223ca9105 -r 9ca3b9b245f8 src/Virt_HostedDependency.c
> --- a/src/Virt_HostedDependency.c	Fri Feb 29 13:04:15 2008 +0100
> +++ b/src/Virt_HostedDependency.c	Fri Feb 29 11:58:09 2008 -0800
> @@ -75,11 +75,12 @@ static CMPIStatus host_to_vs(const CMPIO
>                  goto out;
>
>          conn = connect_by_classname(_BROKER, CLASSNAME(ref), &s);
> -        if (conn == NULL)
> +        if (conn == NULL) {
>                  cu_statusf(_BROKER, &s,
>                             CMPI_RC_ERR_NOT_FOUND,
>                             "No such instance");
>                  goto out;
> +        }
>
>          ret = enum_domains(_BROKER, conn, NAMESPACE(ref), list);
>          if (!ret)
>   
Opps ... that's a bug that slipped in with my patch set "Update single 
instance interface on HostSystem and Adopt HostSystem interface to 
assocs". I will fix this right in the patch set. Thanks "eagle eye" :) !

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor




More information about the Libvirt-cim mailing list