[Libvirt-cim] [PATCH 1 of 5] DevicePool: adopt get_ interface common look and feel

Dan Smith danms at us.ibm.com
Mon Mar 3 16:03:23 UTC 2008


HE> +CMPIStatus get_pool_by_name(const CMPIBroker *broker,
HE> +                            const CMPIObjectPath *reference,
HE> +                            const char *id,
HE> +                            CMPIInstance **_inst)
HE> +{
HE> +        CMPIStatus s = {CMPI_RC_OK, NULL};
HE> +        virConnectPtr conn = NULL;

You add a conn here...

HE>   out:
HE>          inst_list_free(&list);

HE> -        return inst;
HE> +        return s;
HE>  }

...but don't close it here.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080303/b1cf6493/attachment.sig>


More information about the Libvirt-cim mailing list