[Libvirt-cim] [PATCH 1 of 6] ComputerSystem: enhance enum functionality for use in assocs
Dan Smith
danms at us.ibm.com
Mon Mar 3 16:31:38 UTC 2008
JG> if (s.rc != CMPI_RC_OK) {
JG> virDomainFree(list[i]);
JG> continue;
JG> }
JG> should achieve the same functionality but in what I would call a much
JG> cleaner way. Everyone, feel free to chime in here one way or the
JG> other.
That's a valid point, although I would rather have one cleanup path to
avoid leaks in the future. Why not just have the conditional be
(s.rc == CMPI_RC_OK) and do the add there?
Anyway, it's minor so I've applied this patch set.
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080303/153e07c7/attachment.sig>
More information about the Libvirt-cim
mailing list