[Libvirt-cim] [PATCH 2 of 2] Add lookup of domain to make sure it exists as part of the check

[Heidi Eckhart]

Dan Smith wrote:
> HE> Sorry, I know my comment comes a bit late, as the patch is already
> HE> checked in.
>
> That's okay :)
>
> HE> I think this check is not enough. To check if a certain
> HE> Xen/KVM_ComputerSystem or the Xen/KVM_HostSystem object path is
> HE> correct specified by the client, you should use the corresponding
> HE> (new ;)) interfaces (get_domain_by_ref, get_host), as they check
> HE> the complete object path for correctness. It raises the number of
> HE> cycles a bit, but makes the behavior of all providers
> HE> consistent.
>
> Well, the reason I added this is twofold: (1) because of the fact that
> we would fail late if the domain doesn't exist, and (2) because I use
> the dom pointer later for the external check code.
>
> So, I'm more than happy to add in the more rigorous checks, but we
> need this part as well :)
>
>   
ok, fine for me :)

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor