[Libvirt-cim] [PATCH 1 of 2] RegisteredProfile: adopt common look and feel of interfaces

[Dan Smith]

HE> +CMPIStatus get_profile(const CMPIBroker *broker,
HE> +                       const CMPIObjectPath *reference,
HE> +                       const char **properties,
HE> +                       const char* interop_namespace,
HE> +                       const char* pfx,
HE> +                       struct reg_prof *profile,
HE> +                       CMPIInstance **_inst)

This is a really long function signature.  You seem to call it with a
constant for "interop_namespace".  Is there any reason to keep it
variable, instead of just assuming the constant inside the function?

HE>          CMPIStatus s = {CMPI_RC_OK, NULL};
HE>          CMPIInstance *instance = NULL;
HE> -
HE> +        

You add whitespace here.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080313/a791e579/attachment.sig>