[Libvirt-cim] [PATCH] (#2) Add domain ref checking to isMigratable

Heidi Eckhart heidieck at linux.vnet.ibm.com
Thu Mar 13 16:59:26 UTC 2008


Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1205365783 25200
> # Node ID c655c11291a0817c4a804f41bcaa64bbcd34efc5
> # Parent  b739fc9b13320e07a39f3932396c8411c2d4ad75
> (#2) Add domain ref checking to isMigratable
>
> Tested by adding an invalid key to the ComputerSystem REF, which would
> pass before.  It now fails and points out the offending key, as expected.
>
> Changes:
>  - Link to libVirt_ComputerSystem
>  - Use the proper ref and set the namespace, since it's not done for us
>  - Move the Name key extraction up a level to reduce duplication and make
>    the CS ref available for the get_domain_by_ref() call
>
> Signed-off-by: Dan Smith <danms at us.ibm.com>
>
>   
I still have local problems to apply patches, but for me it looks good 
and I trust the others ... +1 :)

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor




More information about the Libvirt-cim mailing list