[Libvirt-cim] [PATCH] [TEST] Make 02_destroysystem actually test the right thing

Dan Smith danms at us.ibm.com
Fri Mar 28 20:34:48 UTC 2008


# HG changeset patch
# User Dan Smith <danms at us.ibm.com>
# Date 1206736402 25200
# Node ID fe283ed5273e0983adf6355c9d6d8e1e81dcdde2
# Parent  612ccb311e273b091659fe14f0471567abe61d08
[TEST] Make 02_destroysystem actually test the right thing

This test was passing incorrectly because it was only looking at the active
domain list instead of active+inactive.  The DestroySystem method in the
provider was only doing a destroy, which means that it disappeared from the
active list and this test considered that a PASS.

Signed-off-by: Dan Smith <danms at us.ibm.com>

diff -r 612ccb311e27 -r fe283ed5273e suites/libvirt-cim/cimtest/VirtualSystemManagementService/02_destroysystem.py
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/02_destroysystem.py	Fri Mar 28 00:03:41 2008 -0700
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/02_destroysystem.py	Fri Mar 28 13:33:22 2008 -0700
@@ -25,7 +25,7 @@ import pywbem
 import pywbem
 from pywbem.cim_obj import CIMInstanceName
 from VirtLib import utils
-from VirtLib.live import active_domain_list
+from VirtLib.live import domain_list
 from XenKvmLib import vsms, vxml
 from XenKvmLib.classes import get_typed_class
 from CimTest.Globals import do_main
@@ -50,7 +50,7 @@ def main():
                                         'Name':default_dom,
                                         'CreationClassName':classname})
     
-    list_before = active_domain_list(options.ip, options.virt)
+    list_before = domain_list(options.ip, options.virt)
     status = PASS
     rc = -1
     
@@ -62,7 +62,7 @@ def main():
         logger.error(details)
         status = FAIL
 
-    list_after = active_domain_list(options.ip, options.virt)
+    list_after = domain_list(options.ip, options.virt)
 
     status = PASS
     if default_dom not in list_before:




More information about the Libvirt-cim mailing list