[Libvirt-cim] [PATCH] [TEST] Adding create_diskpool() function
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Wed May 14 21:03:39 UTC 2008
> +def create_diskpool_conf(server, virt):
> + libvirt_version = virsh_version(server, virt)
> + if virt == 'KVM' and libvirt_version >= '0.4.1' and \
> + CIM_REV > diskpoolconf_rev:
> + status, dpoolname = create_diskpool(server, virt=virt)
> + diskid = "%s/%s" % ("DiskPool", dpoolname)
> + else:
> + status = create_diskpool_file()
> + diskid = "%s/%s" % ("DiskPool", test_dpath)
> +
> + return status, diskid
> +
> +
Forgot to mention this in my review mail, but these functions look
really good. Using the diskid as a return value here is an excellent idea.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list