[Libvirt-cim] [PATCH 2 of 2] [TEST] Remove XFAIL from tests that aren't failing due to a provider bug

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed May 21 21:38:59 UTC 2008


# HG changeset patch
# User Kaitlin Rupert <karupert at us.ibm.com>
# Date 1211403918 25200
# Node ID d1fa24f720402a3fb1263e4f7f93556579e450dd
# Parent  471755570c60cb47caa18d3c2f2b609cdd0e37bc
[TEST] Remove XFAIL from tests that aren't failing due to a provider bug.

This change will cause VirtualSystemManagementService 08_modifyresource.py to fail. This is because the test is attempting to modify the mac address of the network adapter, which isn't a valid attribute to modify.

Will follow-up with a patch to fix this issue.

Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>

diff -r 471755570c60 -r d1fa24f72040 suites/libvirt-cim/cimtest/NetworkPort/01_netport.py
--- a/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py	Wed May 21 14:08:14 2008 -0700
+++ b/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py	Wed May 21 14:05:18 2008 -0700
@@ -45,8 +45,6 @@
 test_dom = "test_domain"
 test_mac = "00:11:22:33:44:55"
 
-bug = "90844"
-
 @do_main(sup_types)
 def main():
     options = main.options
@@ -69,7 +67,7 @@
     except Exception, detail:
         logger.error("Exception: %s" % detail)
         vsxml.undefine(options.ip)
-        return XFAIL_RC(bug)
+        return FAIL
 
     if dev.DeviceID == None:
         logger.error("Error retrieving instance for devid %s" % devid)
diff -r 471755570c60 -r d1fa24f72040 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/05_AddResourcesToResourcePool.py
--- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/05_AddResourcesToResourcePool.py	Wed May 21 14:08:14 2008 -0700
+++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/05_AddResourcesToResourcePool.py	Wed May 21 14:05:18 2008 -0700
@@ -53,8 +53,8 @@
 from CimTest.Globals import do_main, platform_sup
 from XenKvmLib.classes import get_typed_class
 
-cim_errno  = pywbem.CIM_ERR_NOT_SUPPORTED
-cim_desc   = "The requested operation is not supported"
+cim_errno  = pywbem.CIM_ERR_FAILED
+cim_desc   = "Unknown Method"
 cim_mname  = "AddResourcesToResourcePool"
 bug = 92173
 
@@ -74,6 +74,7 @@
         else:
             logger.error("Unexpected rc code %s and description %s\n" \
                                                        %(err_no, desc))
+            print desc
             return XFAIL_RC(bug)
      
     logger.error("The execution should not have reached here!!")
diff -r 471755570c60 -r d1fa24f72040 suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py	Wed May 21 14:08:14 2008 -0700
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/08_modifyresource.py	Wed May 21 14:05:18 2008 -0700
@@ -39,7 +39,6 @@
 nmem = 78
 
 bug_cpu = '90079'
-bug_net = '90853'
 
 @do_main(sup_types)
 def main():
@@ -94,7 +93,7 @@
     except Exception, details:
         logger.error('Error invoking ModifyRS')
         logger.error(details)
-        return XFAIL_RC(bug_net)
+        return FAIL
 
     cxml.undefine(options.ip)
     if rc == -1:




More information about the Libvirt-cim mailing list