[Libvirt-cim] [PATCH] [TEST] LXC support using DefineSystem & VSMS.01

[Kaitlin Rupert]

Zhengang Li wrote:
> My SFCB setup already segfault when VSMS.DefineSystem is invoked. Can 
> someone with a pegasus setup on LXC try this out?

I get the following error:

VirtualSystemManagementService - 01_definesystem_name.py: FAIL
ERROR   - Unexpected rc code 1 and description:
  CIM_ERR_FAILED: ResourceSettings Error: Missing `Address' field
InvokeMethod(DefineSystem): CIM_ERR_FAILED: ResourceSettings Error: 
Missing `Address' field


Where do you see the seg fault at?

Also, I wasn't able to apply this patch cleanly.  Here's some issues I 
noted..



>>                            virt='Xen'):
>>      class_vssd = get_vssd_class(virt)
>>      vssd = class_vssd(name=dom_name, virt=virt)
>> +    +    # LXC only takes disk and memory device for now.

Not sure what caused the double pluses here.

>> +    # Only disk __init__ takes different params.
>> +    if virt == 'LXC':
>> +        d = LXC_DiskResourceAllocationSettingData(
>> +                mountpoint=const.LXC_default_mp, name=dom_name)
>> +    else:
>> +        class_dasd = get_dasd_class(virt)
>> +        if virt == 'KVM':
>> +            disk_dev = 'hda'
>> +            disk_source = const.KVM_disk_path
>> +        elif virt == 'XenFV':
>> +            disk_dev = 'hda'
>> +            disk_source = const.XenFV_disk_path
>> +        d = class_dasd(
>> +                    dev=disk_dev, +                    
>> source=disk_source,

This line also looks weird.

>> +                    name=dom_name)
>>
>> -    class_dasd = get_dasd_class(virt)
>> -    if virt == 'KVM':
>> -        disk_dev = 'hda'
>> -        disk_source = const.KVM_disk_path
>> -    elif virt == 'XenFV':
>> -        disk_dev = 'hda'
>> -        disk_source = const.XenFV_disk_path
>> -    d = class_dasd(
>> -                dev=disk_dev, -                source=disk_source,
>> -                name=dom_name)
>>      class_nasd = get_nasd_class(virt)
>>      if virt == 'KVM':
>>          net_mac= const.KVM_default_mac
>> @@ -237,6 +266,6 @@
>>      m = class_masd(
>>                  megabytes=mem_mb,
>>                  name=dom_name)
>> -
>> +         return vssd.mof(), [d.mof(), n.mof(), p.mof(), m.mof()]

Also, this line already exists in this file.  This is probably an 
unintended change.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com