[Libvirt-cim] [PATCH] [TEST] Move some functions from utils.py to xm_virt_util.py

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Mon Nov 3 22:13:53 UTC 2008


>  > > +def run_remote_guest(ip, domain, command):
>  > > +    """ Execute commands on remote guest console.
>  > > +    """
>  > > +
>  > > +    cmd = 'python %s %s "%s"' % (CONSOLE_APP_PATH, domain, command)
>  > > +
>  > > +    return run_remote(ip, cmd)
>  > > +
>  > > +
>  >
>  >    Kaitlin,
>  >
>  >    I think we can remove run_remote_guest to xm_virt_util.py under
>  > ../libvirt-cim/lib/XenKvmLib,
>  >    because it have to be used by live.py under lib/VirtLib. We have
>  > to make it stay in utils.py.
> 
>      I'm sorry, I intend to say we cann't remove run_remote_guest() from 
> ../lib/XenKvmLib to xm_virt_util.py =)
> 
>  >    Thoughts?
>  >    
>  >    If you agree to make it stay in utils.py, I will rework on this 
> patch.
>  >    Thanks!

I'm sorry Daisy - I'm not sure I understand what you mean here.  Are you 
saying that run_remote_guest() needs to stay in lib/VirtLib/utils.py?

If so, why?

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list