[Libvirt-cim] [PATCH 1 of 2] Add an EmulatedType field to DiskRASD to select CDROM or Disk

[Jim Fehlig]

Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1226005676 28800
> # Node ID 049f0bb012190e680257d00463138391405a5c60
> # Parent  9385e61cd401162bef9c44bc11f64ca349a41abf
> Add an EmulatedType field to DiskRASD to select CDROM or Disk
>
> This seems like a pretty reasonable way to do this, but comments are welcome.
> I had initially planned to have a specific RASD type to represent a CDROM,
> but I don't think that makes much sense, and is significantly more complex.
> Adding this gives us a way to set and query the CDROM-ness of a disk, and
> with the following patch, avoids dropping this qualifier from existing
> configurations.
>
> Signed-off-by: Dan Smith <danms at us.ibm.com>
>
> diff -r 9385e61cd401 -r 049f0bb01219 schema/ResourceAllocationSettingData.mof
> --- a/schema/ResourceAllocationSettingData.mof	Thu Nov 06 09:24:24 2008 -0800
> +++ b/schema/ResourceAllocationSettingData.mof	Thu Nov 06 13:07:56 2008 -0800
> @@ -21,6 +21,10 @@
>        [Description ("Device as seen by the guest")]
>        string VirtualDevice;
>  
> +      [Description ("Device emulation type"),
> +        ValueMap {"0", "1"},
> +        Values {"Disk", "CDROM"}]
> +      uint16 EmulatedType;
>  };
>  
>  [Description ("KVM virtual disk configuration"),
> @@ -32,6 +36,10 @@
>        [Description ("Device as seen by the guest")]
>        string VirtualDevice;
>  
> +      [Description ("Device emulation type"),
> +        ValueMap {"0", "1"},
> +        Values {"Disk", "CDROM"}]
> +      uint16 EmulatedType;
>  };
>   

After thinking about this more (and taking another look at CIM_RASD),
couldn't the existing ResourceType CD Drive or DVD drive be leveraged
instead of adding a new property?

Jim