[Libvirt-cim] [PATCH] [CU] Commented some structures in the std_association.h file

[Dan Smith]

RM>  struct std_assoc {
RM>          char **source_class;
RM> +        /* Defines the list of possible classes that can be passed to the 
RM> +           association for this case */

Can you put the comment above the actual definition?  I think that's
more conventional and intuitive.

RM> +
RM>          char *source_prop;
RM> +        /* Defines the property of the association class that refers 
RM> +           to the input (source class) of this case. This must match
RM> +           that of the schema, and is used for automatic generation of 
RM> +           the reference object in the References() or ReferenceNames()
RM> +           operation */

RM>          char **target_class;
RM> +        /* Same as source_class, applied for target */
RM> +
RM>          char *target_prop;
RM> +        /* Same as source_prop, applied for target */
     
RM>          char **assoc_class;
RM> +        /* Defines the list of association classes which implement this
RM> +           association */

RM>          assoc_handler_t handler;
RM> +        /* Function handler responsible for doing the association and
RM> +           returning the list of target instances of the association.
RM> +           The handler function receives the reference of the source 
RM> +           class of the association and must map it to a list of 
RM> +           CMPIInstance objects (targets of the association). */
RM> +
RM>          make_ref_t make_ref;
RM> +        /* Function handler responsible for creating an instance of the
RM> +           association class as requested by the References() or
RM> +           ReferenceNames() operation.  
RM> +           The handler function receives the source object path,
RM> +           and the target instance, so it can create the reference which is returned

This line looks to be longer than 80 characters.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com