[Libvirt-cim] [PATCH] [TEST] #5 Fix ECTP 01_forward.py to support system with multiple networks defined
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Fri Nov 14 20:35:34 UTC 2008
>> + #FIXME - get_host_info() should be updated to return the host
>> instance
>> + insts = EnumInstances(server, host_ccn, True)
>> + if len(insts) < 1: + logger.error("Expected 1 %s
>> instance", host_ccn)
>> + return FAIL, verify_ectp_list
>>
>>
> The test case will fail for the case where we have sblim-base-provider
> installed with the following error.
> --------------------------------------------------------------------
> ElementConforms - 01_forward.py: FAIL
> ERROR - Expected 1 Linux_ComputerSystem instance
> ERROR - Exception: Failed to get instances needed for verification
> CIM_ERR_INVALID_CLASS: Linux_ComputerSystem
> --------------------------------------------------------------------
>
> This is because we are querying for the Linux_CoumputerSystem with
> 'root/virt' namespace.
> We need to store the previous namespace and change the namespace to
> "Globals.CIM_NS = 'root/cimv2'" depending on if the machine has
> sblim-base-provider installed before enumerating for
> Linux_ComputerSystem and then restore back to the previous namespace.
>
Yes, agreed. Dan recently submitted a fix so that most of the
associations now work with the Linux_ComputerSystem instances. I'll fix
this when I fix the other test cases.
>> +
>> + except Exception, detail:
>> + logger.error("Exception: %s" % detail)
>> + status = FAIL
>>
> Since we are setting the status appropriately in all the cases within
> the try block, I dont think we need to set this explicitly.
If init_vs_pool_values() passes, but then the Associators() call throws
an exception, status is still set to PASS. The test will return PASS in
that case, which wouldn't be valid.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list