[Libvirt-cim] [PATCH] [TEST] Modify HostedDependency.01&02 to call new EnumInstances

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Mon Oct 13 19:41:54 UTC 2008


>> -    keys = ['Name', 'CreationClassName']
>> +   +    cs_class = get_typed_class(options.virt, 'ComputerSystem')
>>      try: -        cs = enumclass.enumerate(server, 'ComputerSystem', 
>> keys, virt)
>> +        cs = enumclass.EnumInstances(server, cs_class)
>>      except Exception,detail:
>>          logger.error(CIM_ERROR_ENUMERATE, 'ComputerSystem')
>>   
> You can use cs_class instead of hardcoding the 'ComputerSystem'.
> otherwise +1 for me.

Agreed.  Can you rework this patch?

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list