[Libvirt-cim] [PATCH] Signed-off-by: Richard Maciel <richardm at br.ibm.com>

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Oct 16 16:54:04 UTC 2008


>                  s = get_migration_caps(ref, &_inst, _BROKER, false);
> -        } else
> +        } else if(STREQC(classname, "ConsoleRedirectionService")) {
> +		CU_DEBUG("before console_rs\n");
> +		s = get_console_rs(ref, &_inst, _BROKER, context, true);
> +		if((s.rc != CMPI_RC_OK) || (_inst == NULL))
> +			goto out;
> +		
> +		CU_DEBUG("before console_rs_caps\n");
> +		s = get_console_rs_caps(_BROKER, ref, &_inst, false);	
> +		if((s.rc != CMPI_RC_OK) || (_inst == NULL))
> +			goto out;

These two lines above aren't needed.  The status will be returned to 
service_to_cap(), and the status will be verified there. Plus, this 
makes the format match the other service_to_cap() calls.

Also, this patch doesn't include the new 
Virt_ConsoleRedirectionServiceCapabilities.h.  That will need to be 
added to the patch.
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list