[Libvirt-cim] [PATCH] [TEST] #2 Updating 04_reverse_errs.py tc of HostedDependency to work with/without sblim-base-provider
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Fri Oct 17 18:41:54 UTC 2008
Deepti B Kalakeri wrote:
>
>
> Kaitlin Rupert wrote:
>>> +def verify_err_fields(cxml, server, conn, keys, classname, +
>>> assoc_classname, msg, field):
>>> + try:
>>> + ret = try_assoc(conn, classname, assoc_classname, keys, +
>>> field_name=field, expr_values=expr_values[field], + bug_no="")
>>> + if ret != PASS:
>>> + if classname == 'Linux_ComputerSystem':
>>> + return XFAIL_RC(bug_sblim)
>>> + else:
>>> + logger.error("--- FAILED: %s---", msg)
>>> + cxml.destroy(server)
>>
>> You also need cxml.undefine() here.
> I removed the cxml.undefine() since cxml.destroy() is just sufficient to
> destroy the domain that was created using cxml.create().
> I had verified this before removing the cxml.undefine(), let me know if
> you still think we need to include cxml.undefine().
Ah, good point. My mistake. =) Your patch is fine as is. I'll apply =)
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list