[Libvirt-cim] [PATCH] [TEST] Addring new tc 01_enum_crs.py to verify CRS fields

Deepti B Kalakeri deeptik at linux.vnet.ibm.com
Fri Oct 24 08:04:10 UTC 2008



Kaitlin Rupert wrote:
>
>> + crs_val = crs[0]
>
> You also want to check the length of crs. The provider should always 
> return an instance, but it's always good to have a check. If something 
> causes the provider not to return an instance and also not return a 
> failure, then you'd be accessing the array out of bounds.
>
Yup, I forgot this check.
Thanks patch with changes submitted.

Regards,
Deepti.




More information about the Libvirt-cim mailing list