[Libvirt-cim] [PATCH 1 of 2]
Dan Smith
danms at us.ibm.com
Tue Oct 28 17:53:09 UTC 2008
KR> + tcp_info = fopen(path, "r");
KR> + if (tcp_info== NULL) {
Whitespace before the == ...
KR> + port_list.list = malloc(count * sizeof(struct vnc_port *));
Why not allocate the space for the structs too?
KR> + port_list.list[port_list.cur] = malloc(sizeof(struct vnc_port));
If you do the above, then you won't have to allocate here.
Otherwise I think it looks fine.
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
More information about the Libvirt-cim
mailing list