[Libvirt-cim] [PATCH] [TEST] Try to fix VSSD-02_bootldr.py by adding a 10s delay at the beginning of test

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Sep 9 16:04:22 UTC 2008


yunguol at cn.ibm.com wrote:
> # HG changeset patch
> # User Guolian Yun <yunguol at cn.ibm.com>
> # Date 1220945607 25200
> # Node ID c69e0d28bed68808d5326d84f6d3b9d70058ee0c
> # Parent  8abcd820b6b37e5fbe8ccc30734cefa908dfab78
> [TEST] Try to fix VSSD-02_bootldr.py by adding a 10s delay at the beginning of test
> 
> Signed-off-by: Guolian Yun <yunguol at cn.ibm.com>
> 
> diff -r 8abcd820b6b3 -r c69e0d28bed6 suites/libvirt-cim/cimtest/VSSD/02_bootldr.py

I wouldn't use a sleep delay here.  Instead, I'd modify this test so 
that it uses cim_define().

Also, I'd change BaseException to Exception.  When this test fails, it 
returns the following error:

ERROR   - NameError : global name 'BaseException' is not defined
Traceback (most recent call last):
   File 
"/data/users/kaitlin/sandbox/cimtest/suites/libvirt-cim/lib/XenKvmLib/const.py", 
line 115, in do_try
     rc = f()
   File "02_bootldr.py", line 73, in main
     except  BaseException, detail :
NameError: global name 'BaseException' is not defined
ERROR   - None


This should be fixed so that we don't see the "global name 
'BaseException' is not defined" error message when the test fails.

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list