[Libvirt-cim] [PATCH] [TEST] Check return code of run_remote() in create_netpool_conf()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Sep 23 01:20:55 UTC 2008


>> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>>
>> diff -r c76b2779aca9 -r 16fd8f755984 
>> suites/libvirt-cim/lib/XenKvmLib/common_util.py
>> --- a/suites/libvirt-cim/lib/XenKvmLib/common_util.py    Mon Sep 22 
>> 07:50:25 2008 -0700
>> +++ b/suites/libvirt-cim/lib/XenKvmLib/common_util.py    Mon Sep 22 
>> 09:45:55 2008 -0700
>> @@ -431,7 +431,8 @@
>>              cmd = "virsh -c %s net-list --all | grep %s" % \
>>                    (utils.virt2uri(virt), net_name)
>>   
> Can you make this as an exact match as below:
> 
> cmd = "virsh -c %s net-list --all | grep *-w *%s" % 
> (utils.virt2uri(virt), net_name)
> 
> This will avoid the cmd returning false positive if in case there is a 
> network pool which is similar to the default networkpool like 
> cimtest-networkpool10 or 10cimtest-networkpool10 exsisting on the machine.

Excellent point - will send a new patch.
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list