[Libvirt-cim] [PATCH] [TEST]Fix HostSystem-01_enum.py with sblim cmpi base provider installed, add Linux_ComputerSystem to enumclass

[Kaitlin Rupert]

Guo Lian Yun wrote:
> 
> libvirt-cim-bounces at redhat.com wrote on 2008-09-23 08:46:00:
> 
>  > > @@ -43,27 +44,35 @@ def main():
>  > >    
>  > >      status = FAIL
>  > >      keys = ['Name', 'CreationClassName']
>  > > -    try:
>  > > -        hs = enumclass.enumerate(options.ip, 'HostSystem', keys,
>  > options.virt)
>  > > -        name = get_typed_class(options.virt, 'HostSystem')
>  > > +
>  > > +    linux_cs = enumclass.enumerate(options.ip, 'ComputerSystem',
>  > keys, 'Linux')
>  >
>  > I think this would be a good chance to fix the behavior of the
>  > enumerate() function.  Instead of passing in both the base name and the
>  > virtualization type, the test itself should call get_typed_class() to
>  > get the proper classname.  That way, this function only needs to take a
>  > classname param.
> 
>   Good idea. But a lot of tests have to update with the behavior of 
> enumerate() function fix.
>   At now, I put fixing HostSystem-01_enum.py with sblim cmpi base 
> provider installed in high
>   priority, so I sill use current enumereate() in my patch. Once it 
> applied, I will start
>   to cook up new enumerate() function and update all related tests.

This sounds like a good plan to me.  Sorry to make so much extra work, 
but I think this will be cleaner - because a lot of the tests are 
already calling get_typed_class() in addition to passing in the basename 
and the virt to the enumerate (and other calls).

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com