[Libvirt-cim] [PATCH 4 of 4] [TEST] Fix HostSystem-01_enum with sblim base provider installed

Guo Lian Yun yunguol at cn.ibm.com
Wed Sep 24 05:51:17 UTC 2008


libvirt-cim-bounces at redhat.com wrote on 2008-09-24 10:02:52:

> > + 
> > +    status, linux_cs = check_sblim(options.ip)
> > +    if status == PASS:
> > +        name = 'Linux_ComputerSystem'
> > +        system = linux_cs[0]
> > +    else:
> 
> You'll want to verify that if check_sblim() passes, that enumerate 
> HostSystem does not return an instance.
 
  Good catch. Add this verification in check_sblim() function.

> 
> > +        try:
> > +            hs = enumclass.enumerate(options.ip, 'HostSystem', 
> keys, options.virt)
> > +            name = get_typed_class(options.virt, 'HostSystem')
> > 
> > -        if len(hs) != 1:
> > -            logger.error("Expected 1 %s instance returned" % name)
> > -            return FAIL
> > +            if len(hs) != 1:
> > +                logger.error("Expected 1 %s instance returned" % 
name)
> > +                return FAIL
> 
> You'll want to return an XFAIL here.
> 
> -- 
> Kaitlin Rupert
> IBM Linux Technology Center
> kaitlin at linux.vnet.ibm.com
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080924/c39d5c24/attachment.htm>


More information about the Libvirt-cim mailing list