[Libvirt-cim] [PATCH] [TEST] #2 patch set of fixing HostSystem-01_enum.py with sblim base provider installed
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Wed Sep 24 19:34:16 UTC 2008
Kaitlin Rupert wrote:
>> + else:
>> + try:
>> + hs = enumclass.enumerate(options.ip, 'HostSystem', keys,
>> options.virt)
>> + name = get_typed_class(options.virt, 'HostSystem')
>> - if len(hs) != 1:
>> - logger.error("Expected 1 %s instance returned" % name)
>> - return FAIL
>> + if len(hs) != 1:
>> + logger.error("Expected 1 %s instance returned" % name)
>> + return XFAIL
>
> This needs to be XFAIL_RC() with a bug number.
My mistake here - this shouldn't be an XFAIL at all. I was confused last
time I reviewed this patch. It should just be a FAIL. Since this bit
of code should only be executed it SBLIM isn't installed, it would be a
failure if HostSystem didn't return an instance.
Sorry for the confusion!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list