[Libvirt-cim] [PATCH 1 of 3] Free virStorageVolPtr in disk_template() in SDC

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Apr 9 23:27:42 UTC 2009


# HG changeset patch
# User Kaitlin Rupert <karupert at us.ibm.com>
# Date 1239243141 14400
# Node ID 58ebddb9670798102bf8fcd4d47a6137b0779571
# Parent  cdf4fa212c15f1b22b0b4b1d1535e1716e1e52d2
Free virStorageVolPtr in disk_template() in SDC

Need to free the pointer each time through the loop.

diff -r cdf4fa212c15 -r 58ebddb96707 src/Virt_SettingsDefineCapabilities.c
--- a/src/Virt_SettingsDefineCapabilities.c	Thu Apr 09 10:07:27 2009 -0700
+++ b/src/Virt_SettingsDefineCapabilities.c	Wed Apr 08 22:12:21 2009 -0400
@@ -1014,6 +1014,9 @@
                 }         
                 
                 s = volume_template(ref, template_type, volptr, list);
+
+                virStorageVolFree(volptr);
+
                 if (s.rc != CMPI_RC_OK)
                         goto out;            
         }
@@ -1024,7 +1027,6 @@
         free(pfx);
         free(volnames);
         free(host);
-        virStorageVolFree(volptr);
         virStoragePoolFree(poolptr);
         virConnectClose(conn);
 




More information about the Libvirt-cim mailing list