[Libvirt-cim] [PATCH] Remove ns param from rasd_to_vpool() in RPCS

[Richard Maciel]

+1

Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1239816487 25200
> # Node ID 4574c6f289f29c9afd2bd3a3434360c17891e9fe
> # Parent  0c6f5aa107a82840acffa2e3931ddf05726c35c5
> Remove ns param from rasd_to_vpool() in RPCS
> 
> This parameter isn't being used by any of the functions.
> 
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
> 
> diff -r 0c6f5aa107a8 -r 4574c6f289f2 src/Virt_ResourcePoolConfigurationService.c
> --- a/src/Virt_ResourcePoolConfigurationService.c	Thu Apr 09 10:07:27 2009 -0700
> +++ b/src/Virt_ResourcePoolConfigurationService.c	Wed Apr 15 10:28:07 2009 -0700
> @@ -78,8 +78,7 @@
>  }
> 
>  static const char *net_rasd_to_pool(CMPIInstance *inst,
> -                                    struct virt_pool *pool,
> -                                    const char *ns)
> +                                    struct virt_pool *pool)
>  {
>          const char *val = NULL;
>          const char *msg = NULL;
> @@ -116,8 +115,7 @@
> 
>  #if VIR_USE_LIBVIRT_STORAGE
>  static const char *disk_rasd_to_pool(CMPIInstance *inst,
> -                                    struct virt_pool *pool,
> -                                    const char *ns)
> +                                    struct virt_pool *pool)
>  {
>          const char *val = NULL;
>          const char *msg = NULL;
> @@ -153,8 +151,7 @@
>  }
>  #else
>  static const char *disk_rasd_to_pool(CMPIInstance *inst,
> -                                    struct virt_pool *pool,
> -                                    const char *ns)
> +                                    struct virt_pool *pool)
>  {
>          return "Storage pool creation not supported in this version of libvirt";
>  }
> @@ -169,15 +166,14 @@
> 
>  static const char *rasd_to_vpool(CMPIInstance *inst,
>                                   struct virt_pool *pool,
> -                                 uint16_t type,
> -                                 const char *ns)
> +                                 uint16_t type)
>  {
>          pool->type = type;
> 
>          if (type == CIM_RES_TYPE_NET) {
> -                return net_rasd_to_pool(inst, pool, ns);
> +                return net_rasd_to_pool(inst, pool);
>          } else if (type == CIM_RES_TYPE_DISK) {
> -                return disk_rasd_to_pool(inst, pool, ns);
> +                return disk_rasd_to_pool(inst, pool);
>          }
> 
>          pool->type = CIM_RES_TYPE_UNKNOWN;
> @@ -215,7 +211,7 @@
>          if (res_type_from_rasd_classname(CLASSNAME(op), &type) != CMPI_RC_OK)
>                  return "Unable to determine resource type";
> 
> -        msg = rasd_to_vpool(inst, pool, type, NAMESPACE(op));
> +        msg = rasd_to_vpool(inst, pool, type);
> 
>          return msg;
>  }
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim


-- 
Richard Maciel, MSc
IBM Linux Technology Center
rmaciel at linux.vnet.ibm.com